Open
Conversation
I had a problem with a <that> with two consecutive stars in it,
one for a person's first name and the second for the last name.
The <thatstar index="2"/> was returning the last name correctly,
but the <thatstar/> or <thatstar index="1"/> kept coming back
empty. It turned out to be that the parser was looking for a
match between the next word in the pattern and the next word in
the that. When the next word was a star, it would not match.
Here is an example:
<aiml>
<category>
<pattern>ASK ME A QUESTION</pattern>
<template>
<random>
<li>Do you listen to <random>
<li>Elvis Presley</li>
<li>Eddie Van Halen</li>
<li>Michael Jackson</li>
</random> music?</li>
</random>
</template>
</category>
<category>
<pattern>YES</pattern>
<that>DO YOU LISTEN TO * * MUSIC</that>
<template>I also listen to Mr. <thatstar index="2"/></template>
</category>
<category>
<pattern>NO</pattern>
<that>DO YOU LISTEN TO * * MUSIC</that>
<template>Well <thatstar/> listens to you!</template>
</category>
</aiml>
This fixes the issue by checking if the next word in a match is
another star and, if so, then stopping after the first word.
|
Any chance to merge it PR ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a problem with a with two consecutive stars in it, one for a person's first name and the second for the last name. The was returning the last name correctly, but the
<thatstar/>or<thatstar index="1"/>kept coming back empty. It turned out to be that the parser was looking for a match between the next word in the pattern and the next word in the words list. When the next word was a star, it would not match.Here is an example:
This fixes the issue by checking if the next word in a match is another star and, if so, then stopping after the first word.
I also took the liberty of adding Jupyter Notebook files to .gitignore so I wouldn't see mine when getting git status.