Deduplicate PSBT inputs in contribute_inputs #1254
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, contribute_inputs would allow duplicate inputs to be added to the transaction. This could lead to invalid transactions if the same input was contributed multiple times or if an input was added that already existed in the transaction. This adds deduplication logic that filters new inputs to exclude any that reference already-seen
Collaborator
Pull Request Test Coverage Report for Build 20663993006Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes: #861
As mentioned in the issue contribute_inputs would allow duplicate PSBT inputs multiple times
As spacebear pointed our
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.