Option to omit transfer on same storage volume#147
Option to omit transfer on same storage volume#147hUwUtao wants to merge 1 commit intopelican-dev:mainfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| // with other nodes in the cluster. When this value is set and matches the value on a target node, | ||
| // Wings will assume the server data already exists on the target and will skip copying and cleanup. | ||
| // When empty, transfers behave normally. | ||
| StoragePool string `yaml:"storage_pool"` |
There was a problem hiding this comment.
I would change this to a struct with an Enabled bool and PoolName stringor something similar to you are not using "" as a value to match to mean enabled.
It would look like this.
StoragePool struct {
Enabled bool `default:"false" yaml:"enabled"`
PoolName string `yaml:"pool_name"`
} `yaml:"storage_pool"`There was a problem hiding this comment.
I know this would change all the other code you wrote but is arguably a better choice.
Hi, I'm building a Ceph based infrastructure that syncs the volume (ex: /var/lib/pelican/volumes) across nodes in cluster. A roadblock is that wings cares about transfer and cleaning up, the stack will not work as expected.
A configuration option is added for the purpose to circumvent this behavior. When configured:
Wings will not attempt to transfer files or cleanup.
It will still move server to
storage_poolthat is not match, but the cleanup will not work at the moment.At the moment, it works with the stack if simply configured with a common name across nodes with the following setup:
If the configuration left empty, wings will behave as just normal.