Skip to content

ext/random: mark rand() as an alias of mt_rand() #20796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Girgias wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −7
Open

ext/random: mark rand() as an alias of mt_rand() #20796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ext/random/random.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,11 @@ function mt_srand(?int $seed = null, int $mode = MT_RAND_MT19937): void {}
/** @alias mt_srand */
function srand(?int $seed = null, int $mode = MT_RAND_MT19937): void {}

function rand(int $min = UNKNOWN, int $max = UNKNOWN): int {}

function mt_rand(int $min = UNKNOWN, int $max = UNKNOWN): int {}

/* @alias mt_rand */
Copy link
Member

@TimWolla TimWolla Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also not a proper docblock (missing asterisk). I don't think this had an effect based on the arginfo diff, otherwise CI should hopefully have caught it.

function rand(int $min = UNKNOWN, int $max = UNKNOWN): int {}

/** @compile-time-eval */
function mt_getrandmax(): int {}

Expand Down
10 changes: 5 additions & 5 deletions ext/random/random_arginfo.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.