Make animated image can resume from next frame after switch back to specified runloop mode#521
Open
zhongwuzw wants to merge 4 commits intopinterest:masterfrom
Open
Make animated image can resume from next frame after switch back to specified runloop mode#521zhongwuzw wants to merge 4 commits intopinterest:masterfrom
zhongwuzw wants to merge 4 commits intopinterest:masterfrom
Conversation
…pecified runloop mode
Generated by 🚫 Danger |
bolsinga
suggested changes
May 20, 2020
Contributor
bolsinga
left a comment
bolsinga
left a comment
There was a problem hiding this comment.
Please add a test for this new feature.
…if_time_mechanism
This reverts commit 1eb9e57.
Contributor
Author
|
@bolsinga Seems it's not easy to test, can you help me? |
Contributor
OK. Thanks for trying. I'm not too familiar with this code, so I was hoping a test would help me review. I'll ask @garrettmoon for a review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason I make this PR is I have a requirement to pause the playback of gif before scroll and resume the next frame after scroll stopped to improve the scrolling performance, I already make an issue to describe, please see #520.