Removes the optimization to reduce the display links frame interval#528
Open
garrettmoon wants to merge 1 commit intomasterfrom
Open
Removes the optimization to reduce the display links frame interval#528garrettmoon wants to merge 1 commit intomasterfrom
garrettmoon wants to merge 1 commit intomasterfrom
Conversation
The idea behind this optimization was to reduce the number of calls the display link would need for animated images which didn't draw every frame. But this has resulted in frames being dropped in certain cases where frameInterval isn't respected (see https://i.pinimg.com/originals/58/9c/e8/589ce828d2ef0797da0e85b1c6d2f2b3.gif) Since the the display link fire method continues if we detect we're at the same image index as before, let's just remove this optimization.
Generated by 🚫 Danger |
|
🚫 CI failed with log |
Contributor
|
Is it possible to add a test covering this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea behind this optimization was to reduce the number of calls the display
link would need for animated images which didn't draw every frame. But this
has resulted in frames being dropped in certain cases where frameInterval isn't
respected (see https://i.pinimg.com/originals/58/9c/e8/589ce828d2ef0797da0e85b1c6d2f2b3.gif)
Since the the display link fire method continues if we detect we're
at the same image index as before, let's just remove this optimization.