#trivial Fix: Download fail when using processor with GIF image#540
Open
Naituw wants to merge 1 commit intopinterest:masterfrom
Open
#trivial Fix: Download fail when using processor with GIF image#540Naituw wants to merge 1 commit intopinterest:masterfrom
Naituw wants to merge 1 commit intopinterest:masterfrom
Conversation
|
🚫 CI failed with log |
|
For gifs, alternate representation is enabled by default, Use |
Contributor
Author
Current implementation will fail on the test I added. I don't mean to disable alternate representation by default for gif, but alternative reps should not created when user want to process the image by a processor. |
Collaborator
|
Can you please rebase this? (sorry for the delayed review!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: Since GIF image become alternate representation, processor can't get an UIImage/NSImage to process, a
PINRemoteImageManagerErrorFailedToFetchImageForProcessingerror is returned.This Fix: Disallow alternate representation when obtaining the image for processing.