Fix RTP NACK responder buffers not released after RemoveTrack/Stop#405
Open
ivanlukomskiy wants to merge 1 commit intopion:masterfrom
Open
Fix RTP NACK responder buffers not released after RemoveTrack/Stop#405ivanlukomskiy wants to merge 1 commit intopion:masterfrom
ivanlukomskiy wants to merge 1 commit intopion:masterfrom
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #405 +/- ##
==========================================
+ Coverage 79.69% 79.71% +0.02%
==========================================
Files 82 88 +6
Lines 4063 4590 +527
==========================================
+ Hits 3238 3659 +421
- Misses 659 748 +89
- Partials 166 183 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, RTP packet history allocated by ResponderInterceptor remains retained after a sender is removed (RemoveTrack) while the PeerConnection stays active. This causes gradual memory growth in applications that dynamically add and remove outbound streams.
This change ensures that per-stream RTP history is properly cleaned up during UnbindLocalStream, preventing unnecessary memory retention while keeping the PeerConnection alive.
Reference issue
Fixes #404 https://github.com/pion/interceptor/issues/404