feat: add AccountInfo reconciler with finalizer subroutine #308
+398
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nexus49
force-pushed
the
feat/accountinfo-finalizer
branch
from
29f805c to
67250e4
Compare
Add a new AccountInfoReconciler that ensures AccountInfo resources cannot be deleted while APIBinding resources in the workspace still have the core.platform-mesh.io/apibinding-finalizer finalizer. - Add AccountInfoFinalizerSubroutine with security.platform-mesh.io/accountinfo-finalizer - Add AccountInfoReconciler using the lifecycle builder pattern - Register controller in operator.go - Add comprehensive unit tests Signed-off-by: Bastian Echterhölter <bastian.echterhoelter@sap.com> On-behalf-of: @SAP <bastian.echterhoelter@sap.com>
nexus49
force-pushed
the
feat/accountinfo-finalizer
branch
from
67250e4 to
a739841
Compare
…orization model Signed-off-by: Bastian Echterhölter <bastian.echterhoelter@sap.com> On-behalf-of: @SAP <bastian.echterhoelter@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AccountInfoReconcilerwithAccountInfoFinalizerSubroutineto manage deletion lifecycle ofAccountInforesourcessecurity.platform-mesh.io/accountinfo-finalizerthat blocksAccountInfodeletion until allAPIBindingresources withcore.platform-mesh.io/apibinding-finalizerare removed from the workspace