Skip to content

Added a build script for onnxruntime1.23.2#7510

Open
BODAPATIMAHESH wants to merge 9 commits intoppc64le:masterfrom
BODAPATIMAHESH:ort_23_2_build
Open

Added a build script for onnxruntime1.23.2#7510
BODAPATIMAHESH wants to merge 9 commits intoppc64le:masterfrom
BODAPATIMAHESH:ort_23_2_build

Conversation

@BODAPATIMAHESH
Copy link

@BODAPATIMAHESH BODAPATIMAHESH commented Nov 12, 2025

Checklist

  • Have you checked and followed all the points mention in the CONTRIBUTING.MD
  • Have you validated script on UBI 9 container
  • Did you run the script(s) on fresh container with set -e option enabled and observe success ?
  • Did you have Legal approvals for patch files ?

Copy link
Contributor

@shubham-dayma-ibm shubham-dayma-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we are not installing opneblas, can you confirm if we don't need that?
Other then this I don't see any new thing added to onnxruntime_1.23.2_ubi_9.5.sh as compared with onnxruntime_1.22.0_ubi_9.3.sh

export SITE_PACKAGE_PATH=/usr/local/lib/python${PYTHON_VERSION}/site-packages
yum remove -y python3-chardet

ln -sf $(ls -1 /usr/bin/python3.[0-9]* | grep -E '^/usr/bin/python3\.[0-9]+$' | sort -V | tail -n 1) /usr/bin/python3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect. The build-script usally runs under wrapper-script, which creates vevn for specific pythonv version. We should not be having python symlink

-DCMAKE_POSITION_INDEPENDENT_CODE=ON \
..
cmake --build .
cmake --install .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usally you don't need to install abseilcpp when you install protobuf. Installing protobuf from source takes care of building abseilcpp, you just need to copy the source of abseilcpp under protobuf source.

Refere below code snippet:

ABSEIL_VERSION=20240116.2
ABSEIL_URL="https://github.com/abseil/abseil-cpp"
git clone $ABSEIL_URL -b $ABSEIL_VERSION
echo " ------------------------------------------ Abseil-CPP Cloned ------------------------------------------ "
cd $CURRENT_DIR
# Setting paths and versions
export C_COMPILER=$(which gcc)
export CXX_COMPILER=$(which g++)
echo "C Compiler set to $C_COMPILER"
echo "CXX Compiler set to $CXX_COMPILER"
LIBPROTO_DIR=$(pwd)
mkdir -p $LIBPROTO_DIR/local/libprotobuf
LIBPROTO_INSTALL=$LIBPROTO_DIR/local/libprotobuf
# Clone Source-code
echo " ------------------------------------------ Libprotobuf Installing ------------------------------------------ "
PACKAGE_VERSION_LIB="v4.25.8"
PACKAGE_GIT_URL="https://github.com/protocolbuffers/protobuf"
git clone $PACKAGE_GIT_URL -b $PACKAGE_VERSION_LIB
# Build libprotobuf
echo "protobuf build starts!!"
cd protobuf
git submodule update --init --recursive
rm -rf ./third_party/googletest | true
rm -rf ./third_party/abseil-cpp | true
cp -r $CURRENT_DIR/abseil-cpp ./third_party/

1. build_script mapped to the latest build-script
2. Installed abseil from protobuf.
@shubham-dayma-ibm
Copy link
Contributor

@BODAPATIMAHESH get approval from distro first.

@BODAPATIMAHESH
Copy link
Author

I see we are not installing opneblas, can you confirm if we don't need that? Other then this I don't see any new thing added to onnxruntime_1.23.2_ubi_9.5.sh as compared with onnxruntime_1.22.0_ubi_9.3.sh

We don't need openblas for onnxruntime build and inferencing @shubham-dayma-ibm

@BODAPATIMAHESH
Copy link
Author

@anjiltech can you review the changes.



"python$PYTHON_VERSION" -m venv --system-site-packages VENV_DIR
source VENV_DIR/bin/activate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove creation of python venv

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@shubham-dayma-ibm shubham-dayma-ibm self-requested a review February 11, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants