Added a build script for onnxruntime1.23.2#7510
Added a build script for onnxruntime1.23.2#7510BODAPATIMAHESH wants to merge 9 commits intoppc64le:masterfrom
Conversation
shubham-dayma-ibm
left a comment
There was a problem hiding this comment.
I see we are not installing opneblas, can you confirm if we don't need that?
Other then this I don't see any new thing added to onnxruntime_1.23.2_ubi_9.5.sh as compared with onnxruntime_1.22.0_ubi_9.3.sh
| export SITE_PACKAGE_PATH=/usr/local/lib/python${PYTHON_VERSION}/site-packages | ||
| yum remove -y python3-chardet | ||
|
|
||
| ln -sf $(ls -1 /usr/bin/python3.[0-9]* | grep -E '^/usr/bin/python3\.[0-9]+$' | sort -V | tail -n 1) /usr/bin/python3 |
There was a problem hiding this comment.
This is incorrect. The build-script usally runs under wrapper-script, which creates vevn for specific pythonv version. We should not be having python symlink
| -DCMAKE_POSITION_INDEPENDENT_CODE=ON \ | ||
| .. | ||
| cmake --build . | ||
| cmake --install . |
There was a problem hiding this comment.
Usally you don't need to install abseilcpp when you install protobuf. Installing protobuf from source takes care of building abseilcpp, you just need to copy the source of abseilcpp under protobuf source.
Refere below code snippet:
build-scripts/o/onnx/onnx_ubi_9.3.sh
Lines 119 to 153 in 8197a06
|
@BODAPATIMAHESH get approval from distro first. |
We don't need openblas for onnxruntime build and inferencing @shubham-dayma-ibm |
|
@anjiltech can you review the changes. |
|
|
||
|
|
||
| "python$PYTHON_VERSION" -m venv --system-site-packages VENV_DIR | ||
| source VENV_DIR/bin/activate |
There was a problem hiding this comment.
remove creation of python venv
b8fc867 to
1d4b6ff
Compare
1d4b6ff to
90fea93
Compare
Checklist
set -eoption enabled and observe success ?