Docker image for openwebui-pipelines#7895
Docker image for openwebui-pipelines#7895vikashsingh14 wants to merge 4 commits intoppc64le:masterfrom
Conversation
| rm -rf /app/.git && \ | ||
| find /app -name '*.pyc' -o -name '*.pyo' -o -name '__pycache__' -type f -delete | ||
|
|
||
| COPY requirements.txt /app/requirements.txt |
There was a problem hiding this comment.
from where are users supposed to copy requirements.txt? Why are you not updating existing requirements.txt?
There was a problem hiding this comment.
from where are users supposed to copy requirements.txt? Why are you not updating existing requirements.txt?
Hi @Sapana-Khemkar, Sure I will update it!!
|
Why you have created folder pipelines-openwebui_python311_main inside Dockerfiles folder? Do you really need it? |
There was a problem hiding this comment.
what is purpose of this file?
There was a problem hiding this comment.
I created a build.sh script to build image but noticed no one else uses it in build script repo, I have deleted it!
| patchelf semantic_version build | ||
|
|
||
| WORKDIR /app | ||
| COPY patches /patches |
There was a problem hiding this comment.
use wget for copying patches. Don't assume it is available on host machine
There was a problem hiding this comment.
mkdir -p /patches &&
wget -q -O /patches/libdatadog-crashtracker_25.0.0.patch
https://raw.githubusercontent.com/vikashsingh14/build-scripts/openwebui-pipelines-dockerfile/o/openwebui-pipelines/ubi9-pipelines-v1.0.0/patches/libdatadog-crashtracker_25.0.0.patch
Done!!
| /opt/venv/bin/pip install /tmp/ddtrace-*.whl && \ | ||
| rm -rf /tmp/* && \ | ||
| git clone --depth=1 https://github.com/open-webui/pipelines.git . && \ | ||
| patch -p1 < /patches/requirements.patch && \ |
There was a problem hiding this comment.
why have you not used git apply here?
There was a problem hiding this comment.
I modified docker file & used
git apply /patches/pipelines_requirements.patch
Done!!
Purva suggested this approach because Pratik recommended this folder structure to her. But now as you suggested (In Dockerfiles we generally create folder based on base image name and package version. In you case it is not both) Done!! |
|
Hi @Sapana-Khemkar, PR is ready for review, please review. |
This PR adds the Docker image for openwebui-pipelines.
Checklist