-
-
Notifications
You must be signed in to change notification settings - Fork 84
Fix citation details #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kss682
wants to merge
2
commits into
precice:master
Choose a base branch
from
kss682:issue522
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix citation details #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add user-agent to google scholar request - Align citation buttons - Update default values in config - Add citation id in config
Collaborator
Author
Member
|
Are there any usage/request limits? |
Collaborator
Author
|
It does have a rate limit which is what happens when we run it locally multiple times, that usually gives a 429. |
MakisH
added a commit
to MakisH/precice.github.io
that referenced
this pull request
Dec 30, 2025
Related to precice#527 Hard-coding till that is merged, since the data is currently wrong. Google Scholar seems to have changed which works it includes in this list. Related to precice#522
MakisH
added a commit
that referenced
this pull request
Dec 30, 2025
Member
|
In #651, I updated the hard-coded data, and added a URL to the v1 paper. I created the following conflicts that should be easy to fix, depending on the future direction of this PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

PR fixes #522