Take 2: Added editorconifg, and ran phpcs fixes for uninstall file#16
Take 2: Added editorconifg, and ran phpcs fixes for uninstall file#16bhubbard wants to merge 1 commit intopressable:mainfrom
Conversation
- Updated composer packages
- Added editorconfig file
- Ran phpcs fixes for uninstall.php
There is one remaining issue which is a commented out line to include one file:
```include_once ('remove_mu_plugins_batcache_on_uninstall.php');```
WalkthroughThe changes introduce a project-wide .editorconfig file to standardize coding conventions and refactor uninstall.php to use require_once and simplify permission checks while preserving all existing deletion behavior. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.editorconfig (1)
16-23: Consider covering*.yamland ensuring newline at EOFIf this repo ever uses
.yamlin addition to.yml, you may want to include it in the YAML section; also, sinceinsert_final_newline = true, ensure this file itself ends with a newline to avoid minor tooling warnings.uninstall.php (1)
20-61: Option cleanup block looks consistentThe
delete_option()list is straightforward and consistent; behaviorally this matches a typical uninstall routine. If you ever want to DRY it up, you could push the option names into an array and loop, but that’s purely a style/maintainability choice, not a blocker.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
composer.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
.editorconfig(1 hunks)uninstall.php(1 hunks)
🔇 Additional comments (1)
.editorconfig (1)
1-24: Editorconfig matches WordPress conventionsSettings (tabs for code, LF by default, CRLF for
wp-config-sample.php, no trimming in Markdown) all look consistent with typical WordPress standards. Nothing blocking here.
There is one remaining issue which is a commented out line to include one file:
include_once ('remove_mu_plugins_batcache_on_uninstall.php');Summary by CodeRabbit
Chores
Refactor
✏️ Tip: You can customize this high-level summary in your review settings.