Skip to content

octo4a fix #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kdobrev wants to merge 3 commits into
base: main
Choose a base branch
from
Open

octo4a fix #38

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64ec4b8
added find_package(ZLIB REQUIRED "1.0") to cmakelists
kdobrev Dec 10, 2023
31e3d30
fix find package zlib
kdobrev Dec 10, 2023
00ca79f
octo4a fix
kdobrev Dec 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ install(TARGETS ${_libname}
INCLUDES DESTINATION include/${PROJECT_NAME}
)

find_package(ZLIB REQUIRED "1.0")
Copy link

@jneilliii jneilliii Mar 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be find_package(ZLIB "1.0" REQUIRED)?

Copy link

@MichaIng MichaIng Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, at least for newer cmake, it needs to be that way round: https://cmake.org/cmake/help/latest/command/find_package.html

Suggested change
find_package(ZLIB REQUIRED "1.0")
find_package(ZLIB "1.0" REQUIRED)


foreach(_comp ${_selected_components})
# Install targets and headers
string(TOLOWER ${_comp} _comp_lower)
Expand Down