[ET-VK] Add Vulkan 1.0 compatibility for extension feature querying#17193
Merged
[ET-VK] Add Vulkan 1.0 compatibility for extension feature querying#17193
Conversation
added 3 commits
February 3, 2026 09:36
…ception-safe Refactored Context::flush() by extracting two new public functions: - wait_for_queue(): blocks until the GPU queue is idle - clear_resources(): clears command/descriptor pools and cleanup lists This allows callers to use these operations independently. ComputeGraph's destructor now uses these functions directly and wraps them in try/catch blocks to ensure it never throws exceptions, following C++ best practices for destructors. Authored with Claude. Differential Revision: [D92171362](https://our.internmc.facebook.com/intern/diff/D92171362/) ghstack-source-id: 337901647 Pull Request resolved: #17158
The original code created pipelines for all descriptors but used a separate index counter during cache insertion that only incremented for non-cached entries. This caused incorrect pipeline handles to be associated with keys when some descriptors were already cached, and leaked handles for duplicates. Fix by filtering out already-cached descriptors upfront, ensuring 1:1 correspondence between the created pipelines array and cache insertions. Authored with Claude. Differential Revision: [D92171360](https://our.internmc.facebook.com/intern/diff/D92171360/) ghstack-source-id: 337901649 Pull Request resolved: #17159
Pull Request resolved: #17160 The previous implementation used `vkGetPhysicalDeviceFeatures2` unconditionally, which is only available in Vulkan 1.1+. Devices running Vulkan 1.0 would fail to query extension features correctly. This change refactors PhysicalDevice to detect the API version at runtime and use the appropriate method: - Vulkan 1.0: Uses KHR extension functions (vkGetPhysicalDeviceFeatures2KHR) obtained via vkGetInstanceProcAddr, with graceful fallback if unavailable - Vulkan 1.1+: Uses core vkGetPhysicalDeviceFeatures2 directly Also fixes a bug where shader_int_dot_product_properties was incorrectly chained into the features linked list instead of being queried separately via vkGetPhysicalDeviceProperties2. This PR was authored with Claude. ghstack-source-id: 337979631 @exported-using-ghexport Differential Revision: [D92171361](https://our.internmc.facebook.com/intern/diff/D92171361/)
pytorch-bot
bot
added
the
module: vulkan
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17193
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 65bc680 with merge base 593775b ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
SS-JIA
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #17160 by @SS-JIA
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/404/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/404/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/403/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/404/orig
Differential Revision: D92171361
@diff-train-skip-merge
cc @SS-JIA @manuelcandales @digantdesai @cbilgin