Skip to content

[WIP] Update data buffer validation in impl_like for portable builds#17196

Closed
Copilot wants to merge 1 commit intofollow_up_2from
copilot/sub-pr-17195
Closed

[WIP] Update data buffer validation in impl_like for portable builds#17196
Copilot wants to merge 1 commit intofollow_up_2from
copilot/sub-pr-17195

Conversation

Copy link
Contributor

Copilot AI commented Feb 4, 2026

  • Add c10/util/safe_numerics.h include to bundled_program.cpp
  • Add overflow checks in numel calculation loop using c10::mul_overflows
  • Add overflow check for final multiplication by element size
  • Test the changes to ensure they work correctly

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 4, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17196

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 4, 2026
@psiddh psiddh closed this Feb 4, 2026
Copilot AI requested a review from psiddh February 4, 2026 07:02
Copilot stopped work on behalf of psiddh due to an error February 4, 2026 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants