NXP Backend: Add option for prefetching weights from external memory#17199
Open
jirioc wants to merge 1 commit intopytorch:mainfrom
Open
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17199
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Awaiting Approval, 4 New Failures, 1 Unrelated FailureAs of commit e7feb15 with merge base 059c729 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Models that do not fit into SRAM can be placed into external memory. Since the Neutron has no access to external FLASH, the firmware needs to prefetch the weights from FLASH to SRAM in advance. This commit instructs the Neutron Converter to create extra instructions for such prefetching. Each prefetching is started in parallel with the compute, but can take longer, so this feature needs to be used only when necessary.
This commit changes only the AoT part, the necessary runtime changes are yet to be implemented in different PR.
Test plan
Unit test added to backends/nxp/tests/test_neutron_converter_manager.py
cc @robert-kalmar @JakeStevens @digantdesai