QObject: Fixed QObject::connect connection type has different behaviors#123
Open
QObject: Fixed QObject::connect connection type has different behaviors#123
Conversation
…iors when using Qt::AutoConnection and Qt::QueuedConnection in cross-thread
For example:
class MyThread : public QThread
{
Q_OBJECT
public:
void run() override
{
QMap<int, int> result;
//do something, then emit signal after task finished
emit taskFinished(result);
}
signals:
void taskFinished(const QMap<int, int>& result);
};
class MyWidget : public QWidget
{
Q_OBJECT
public:
MyWidget()
{
MyThread* myThread = new MyThread();
//If connection type is Qt::QueuedConnection, the taskFinished(result) signal can be triggered normally and the slot can be executed normally
QObject::connect(myThread, &MyThread::taskFinished, this, &MyWidget::onTaskFinished, Qt::QueuedConnection);
//If not set connection type (Qt::AutoConnection as default), when thread emit taskFinished(result) it will output error
//QObject::connect: Cannot queue arguments of type 'QMap<int,int>'
//(Make sure 'QMap<int,int>' is registered using qRegisterMetaType().)
QObject::connect(myThread, &MyThread::taskFinished, this, &MyWidget::onTaskFinished);
myThread->start();
}
public slots:
void onTaskFinished(const QMap<int, int>& result)
{
//do something
}
};
|
txdy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QObject: Fixed QObject::connect connection type has different behaviors when using Qt::AutoConnection and Qt::QueuedConnection in cross-thread
For example:
class MyThread : public QThread
{
Q_OBJECT
public:
void run() override
{
QMap<int, int> result;
signals:
void taskFinished(const QMap<int, int>& result);
};
class MyWidget : public QWidget
{
Q_OBJECT
public:
MyWidget()
{
MyThread* myThread = new MyThread();
public slots:
void onTaskFinished(const QMap<int, int>& result)
{
//do something
}
};