refactor: Use tsconfig-paths library for robust config parsing#43
Merged
lightninglu10 merged 2 commits intomainfrom Dec 1, 2025
Merged
refactor: Use tsconfig-paths library for robust config parsing#43lightninglu10 merged 2 commits intomainfrom
lightninglu10 merged 2 commits intomainfrom
Conversation
Replace fragile regex-based tsconfig.json parsing with the tsconfig-paths library which properly handles: - JSON with comments (TypeScript's JSON5-like syntax) - The "extends" field to resolve inherited configurations - Complex path patterns and multi-line definitions Also moves fs/path to top-level imports. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
86ab625 to
4dd57ea
Compare
Tests cover: - Basic path alias parsing - JSON with comments (single-line, multi-line, trailing commas) - Extended tsconfig files (extends field resolution) - Webpack resolve.alias taking precedence - Next.js fallback behavior - Edge cases (missing tsconfig, no compilerOptions, multiple targets) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the fragile regex-based tsconfig.json parsing with the well-tested
tsconfig-pathslibrary.Problem
The previous implementation used regex to parse tsconfig.json:
This approach had several limitations:
extendsfield to resolve inherited configurationsSolution
Use the
tsconfig-pathslibrary which:json5parser to handle comments and trailing commasextendschainsChanges
tsconfig-pathsas a dependencyloadConfig()from tsconfig-pathsfsandpathto top-level imports (also addresses refactor: Move fs/path to top-level imports in webpack plugin #39)Test plan
npm run buildpassesnpm testpasses (104 tests)🤖 Generated with Claude Code