Conversation
There was a problem hiding this comment.
🟡 OPTIONAL: Consider also including organizationId in the SWC-injected window.__CODEPRESS_CONFIG__ to keep behavior consistent with the Babel plugin. This would require threading organization_id through the SWC plugin config similarly to repo_name and branch_name.
There was a problem hiding this comment.
Review Summary
This PR refines how CodePress configuration and metadata are exposed and documented.
Key changes reviewed
- README updates documenting the new optional
organization_idoption for both SWC and Babel plugins. - SWC plugin change to defer meta tag injection into
document.headviasetTimeout(0), reducing interference with React Portal-based libraries. - Babel plugin update to accept an
organization_idoption and thread it intowindow.__CODEPRESS_CONFIG__alongsiderepoandbranch. - Type definition update for
CodePressPluginOptionsto include the neworganization_idfield with helpful documentation.
Comments
- Left one 🟡 OPTIONAL comment suggesting parity by also wiring
organization_idthrough the SWC plugin so itswindow.__CODEPRESS_CONFIG__payload matches the Babel plugin.
Assessment
- The changes are internally consistent, backwards compatible, and improve configurability and robustness. No blocking issues found from this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adjust CodePress configuration propagation and documentation.
Changes