tema validator raffa#37
Open
MobR10 wants to merge 5 commits intofeature/controller-service-repository-test-raffafrom
Open
tema validator raffa#37MobR10 wants to merge 5 commits intofeature/controller-service-repository-test-raffafrom
MobR10 wants to merge 5 commits intofeature/controller-service-repository-test-raffafrom
Conversation
Feature/raffa tema validator fix
radu103
reviewed
May 24, 2023
| } | ||
|
|
||
| private static void validateCarYear(Integer year) { | ||
| if(year > YearMonth.now().getYear()){ |
Owner
There was a problem hiding this comment.
validateCar_year_null test fails because of missing year == null check in this function ?
radu103
reviewed
May 24, 2023
| } | ||
| } | ||
|
|
||
| Car carForMaker(String maker) { |
Owner
There was a problem hiding this comment.
you can move all these private functions and used them from a static class re-usable for all tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not for merge, but we ll see