Add steam to rsetup by RadxaPanda · Pull Request #65 · radxa-pkg/rsetup

RadxaPanda · 2024-06-21T07:55:55Z

No description provided.

src/usr/lib/rsetup/cli/steam.sh

debian/control

src/usr/lib/rsetup/cli/steam.sh

RadxaYuntian · 2024-06-26T11:00:15Z

There is now a common function to get user account, then you can use it to get home.

Signed-off-by: ZHANG Yuntian <yt@radxa.com>

Also remove steam_dir before mv operation. Signed-off-by: ZHANG Yuntian <yt@radxa.com>

Signed-off-by: ZHANG Yuntian <yt@radxa.com>

This is assumed from rsetup init code. Signed-off-by: ZHANG Yuntian <yt@radxa.com>

Signed-off-by: ZHANG Yuntian <yt@radxa.com>

RadxaYuntian

Currently I can install steam with following commands:

sudo --preserve-env=https_proxy apt update
sudo --preserve-env=https_proxy apt install -y jq

cat << EOF >steam.sh
set -e
$(curl -Ls "https://raw.githubusercontent.com/RadxaPanda/rsetup/main/src/usr/lib/rsetup/cli/steam.sh")
__parameter_count_check() {
    :
}
set -x
install_steam
EOF

sudo --preserve-env=https_proxy bash ./steam.sh

Running winecfg resulted in following error:

radxa@rock-5-itx:~$ wine winecfg
Box86 with Dynarec v0.3.7 fcbebfa8 built on Jul  7 2024 01:13:25
Error: file is not found (check BOX86_PATH)

steam can be launched from terminal.

RadxaYuntian · 2024-07-11T10:39:20Z

After steam installer unpacked, there is a missing dependency of zenity, and seems crashed during loading of steamui.so.

RadxaPanda · 2024-07-15T02:42:39Z

Currently I can install steam with following commands:

sudo --preserve-env=https_proxy apt update
sudo --preserve-env=https_proxy apt install -y jq

cat << EOF >steam.sh
set -e
$(curl -Ls "https://raw.githubusercontent.com/RadxaPanda/rsetup/main/src/usr/lib/rsetup/cli/steam.sh")
__parameter_count_check() {
    :
}
set -x
install_steam
EOF

sudo --preserve-env=https_proxy bash ./steam.sh

Running winecfg resulted in following error:

radxa@rock-5-itx:~$ wine winecfg
Box86 with Dynarec v0.3.7 fcbebfa8 built on Jul  7 2024 01:13:25
Error: file is not found (check BOX86_PATH)

steam can be launched from terminal.

Now with my latest commit wine winecfg does "nothing" but manually invoking ~/wine/bin/winecfg opens the config
And also steam works fine, i was able to play stardew valley

src/usr/lib/rsetup/cli/steam.sh

RadxaYuntian · 2024-07-15T08:20:51Z

Also what is the complete installation process? Run the script then manually with ~/wine/bin/winecfg? If there is mandatory manual steps then the script should let the user know.

RadxaPanda · 2024-07-16T01:04:43Z

Also what is the complete installation process? Run the script then manually with ~/wine/bin/winecfg? If there is mandatory manual steps then the script should let the user know.

Issue was caused by not properly escaping $@ in the script (was being set to nothing)

src/usr/lib/rsetup/cli/steam.sh

Co-authored-by: ZHANG Yuntian <yt@radxa.com>

RadxaYuntian · 2024-07-17T06:00:07Z

@CodeChenL please check if you can install and launch Steam & some Windows games successfully.

No need to test uninstall.

CodeChenL

Native and proton translations work fine, but performance is low, only some 2D games with low resolution can be played.Like terraria.

src/usr/lib/rsetup/cli/steam.sh

Co-authored-by: CodeChenL <43897062+CodeChenL@users.noreply.github.com>

RadxaPanda · 2024-07-17T07:37:02Z

Native and proton translations work fine, but performance is low, only some 2D games with low resolution can be played.Like terraria.

When i tried this on panfork i was getting better performance than on panthor

src/usr/lib/rsetup/cli/steam.sh

RadxaPanda · 2024-07-25T02:32:14Z

This should be able to be merged

RadxaYuntian · 2024-07-25T02:49:25Z

Right now the functionality is tested, but the code still needs more clean up before it can be merged.

RadxaPanda · 2024-07-25T04:45:25Z

My commit message is bad doesn't is spelled incorrectly

RadxaYuntian · 2024-07-29T09:19:42Z

src/usr/lib/rsetup/cli/steam.sh

+install_box64() {
+    curl -Ls https://ryanfortner.github.io/box64-debs/box64.list > /etc/apt/sources.list.d/box64.list
+    curl -Ls https://ryanfortner.github.io/box64-debs/KEY.gpg | gpg --dearmor --batch --yes -o /etc/apt/trusted.gpg.d/box64-debs-archive-keyring.gpg
+    apt-get update -y && apt-get install -y box64-rk3588


This can be listed in Depends of the repackaged steam.

RadxaYuntian · 2024-07-29T09:19:47Z

src/usr/lib/rsetup/cli/steam.sh

+install_box86() {
+    curl -Ls https://itai-nelken.github.io/weekly-box86-debs/debian/box86.list > /etc/apt/sources.list.d/box86.list
+    curl -Ls https://itai-nelken.github.io/weekly-box86-debs/debian/KEY.gpg | gpg --dearmor --batch --yes -o /etc/apt/trusted.gpg.d/box86-debs-archive-keyring.gpg
+    apt-get update -y && apt-get install -y box86


This can be listed in Depends of the repackaged steam.

RadxaYuntian · 2024-07-29T09:21:25Z

src/usr/lib/rsetup/cli/steam.sh

+    wget https://cdn.cloudflare.steamstatic.com/client/installer/steam.deb
+    ar x steam.deb
+    tar xf data.tar.xz
+
+    # move deb contents to steam folder
+    mv ./usr/* "$steam_dir"
+    popd || return 1
+    rm -rf "$temp_dir"


Those can be the content of the repackaged steam. Can we still install steam under say /usr/lib/x86_64-linux-gnu?

Definitely can but then ull need to rebuild once in a while I think but it should be fine

RadxaYuntian · 2024-07-29T09:25:36Z

src/usr/lib/rsetup/cli/steam.sh

+    wine_pkg="$(sudo -u "$(logname)" mktemp -d)"
+    pushd "$wine_pkg" || return 1
+    latest_version="$(basename "$(curl -ILs -o /dev/null -w "%{url_effective}" https://github.com/Kron4ek/Wine-Builds/releases/latest)")"
+    curl -Lso "wine-$latest_version-x86.tar.xz" "https://github.com/Kron4ek/Wine-Builds/releases/download/$latest_version/wine-$latest_version-x86.tar.xz"


Make a wine package and install under /usr/lib/x86_64-linux-gnu as well

feat: add steam to rsetup

6774ce0

RadxaPanda requested a review from RadxaYuntian as a code owner June 21, 2024 07:55

RadxaPanda marked this pull request as draft June 21, 2024 07:56

RadxaYuntian requested changes Jun 21, 2024

View reviewed changes

RadxaYuntian mentioned this pull request Jun 21, 2024

feat: cli: add autologin function #62

Merged

fix: add requirested changes

f5dfb9e

RadxaYuntian added 12 commits July 10, 2024 16:20

fix: curl with -Ls to follow 302 redirection

728f67f

Signed-off-by: ZHANG Yuntian <yt@radxa.com>

fix: overwrite existing keyring

828adcd

Signed-off-by: ZHANG Yuntian <yt@radxa.com>

fix: use redirection as -o won't overwrite existing file

521b7e0

Signed-off-by: ZHANG Yuntian <yt@radxa.com>

refactor: wrap package list

ba18f2e

Signed-off-by: ZHANG Yuntian <yt@radxa.com>

refactor: move foreign arch setup to parent function

617307f

Signed-off-by: ZHANG Yuntian <yt@radxa.com>

fix: avoid GitHub API due to quota limit

70c0c5b

Signed-off-by: ZHANG Yuntian <yt@radxa.com>

fix: use HEAD instead GET to avoid data download

64fa98d

Signed-off-by: ZHANG Yuntian <yt@radxa.com>

refactor: create run script directly in the final destination

861365d

Signed-off-by: ZHANG Yuntian <yt@radxa.com>

refactor: unpack steam.deb in a temp dir

0836e12

Also remove steam_dir before mv operation. Signed-off-by: ZHANG Yuntian <yt@radxa.com>

refactor: use logname to get real user

2377b9a

Signed-off-by: ZHANG Yuntian <yt@radxa.com>

fix: remove duplicated set -e

94d9721

This is assumed from rsetup init code. Signed-off-by: ZHANG Yuntian <yt@radxa.com>

refactor: replace cd with pushd/popd

e754cf0

Signed-off-by: ZHANG Yuntian <yt@radxa.com>

RadxaYuntian force-pushed the main branch 2 times, most recently from 7ca3725 to 4b92694 Compare July 11, 2024 10:08

fix: ensure wine install with correct file owner

a264dfe

Signed-off-by: ZHANG Yuntian <yt@radxa.com>

RadxaYuntian force-pushed the main branch from 4b92694 to a264dfe Compare July 11, 2024 10:09

RadxaYuntian requested changes Jul 11, 2024

View reviewed changes

fix: wine and steam not being able to launch

2fc4ce1

RadxaPanda marked this pull request as ready for review July 15, 2024 02:40

RadxaPanda requested a review from RadxaYuntian July 15, 2024 02:50

RadxaYuntian requested changes Jul 15, 2024

View reviewed changes

src/usr/lib/rsetup/cli/steam.sh Outdated Show resolved Hide resolved

RadxaPanda added 2 commits July 15, 2024 17:39

fix: escape $HOME and $@ when creating executables for wine and steam

e9c9610

fix: add an ignore shellcheck option

b95ed9a

RadxaYuntian requested changes Jul 16, 2024

View reviewed changes

src/usr/lib/rsetup/cli/steam.sh Show resolved Hide resolved

src/usr/lib/rsetup/cli/steam.sh Outdated Show resolved Hide resolved

chore: use cat instead of echo for the steam executable

46f30b5

Co-authored-by: ZHANG Yuntian <yt@radxa.com>

RadxaYuntian requested a review from CodeChenL July 17, 2024 05:59

CodeChenL requested changes Jul 17, 2024

View reviewed changes

src/usr/lib/rsetup/cli/steam.sh Outdated Show resolved Hide resolved

chore: fix typo in the steam executable

5a4a751

Co-authored-by: CodeChenL <43897062+CodeChenL@users.noreply.github.com>

CodeChenL reviewed Jul 17, 2024

View reviewed changes

src/usr/lib/rsetup/cli/steam.sh Outdated Show resolved Hide resolved

RadxaPanda and others added 2 commits July 17, 2024 15:47

chore: fix binfmtd

c17f096

feat: improve Steam installation prompt for devices without panthor

e9f9456

RadxaPanda requested a review from RadxaYuntian July 25, 2024 02:31

chore: fix uninstall so it doesnt remove every single package it finds

428b93a

RadxaYuntian requested changes Jul 29, 2024

View reviewed changes

Conversation

RadxaPanda commented Jun 21, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RadxaYuntian commented Jun 26, 2024

Uh oh!

RadxaYuntian left a comment

Choose a reason for hiding this comment

Uh oh!

RadxaYuntian commented Jul 11, 2024

Uh oh!

RadxaPanda commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

RadxaYuntian commented Jul 15, 2024

Uh oh!

RadxaPanda commented Jul 16, 2024

Uh oh!

Uh oh!

Uh oh!

RadxaYuntian commented Jul 17, 2024

Uh oh!

CodeChenL left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RadxaPanda commented Jul 17, 2024

Uh oh!

Uh oh!

RadxaPanda commented Jul 25, 2024

Uh oh!

RadxaYuntian commented Jul 25, 2024

Uh oh!

RadxaPanda commented Jul 25, 2024

Uh oh!

RadxaYuntian Jul 29, 2024

Choose a reason for hiding this comment

Uh oh!

RadxaYuntian Jul 29, 2024

Choose a reason for hiding this comment

Uh oh!

RadxaYuntian Jul 29, 2024

Choose a reason for hiding this comment

Uh oh!

RadxaPanda Jul 29, 2024

Choose a reason for hiding this comment

Uh oh!

RadxaYuntian Jul 29, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

RadxaPanda commented Jul 15, 2024 •

edited

Loading