Fix MSVC build problems caused by 'windows.h' #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@WagnerChristoph Please ignore all the CI build failures - they're our fault, not your fault 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the problem when building with MSVC due to a macro conflict, arising from including
windows.hwithout a preceding#define NOMINMAX(as it re-definesmin/maxotherwise).In this case,
picoboot_connection.hincluded thelibusb.hheader unguardedly, which in turn includeswindows.h. This was previously fixed with#undef min/max, but inmain.cpponly after includingmodel.h, where the error occurred.Also added the guard to
portable_endian.h, the other place wherewindows.hmight be included (throughwinsock2.h), and cleaned up the now obsolete#undefs.Fixes #288.