Open
Conversation
Contributor
|
Please add note which new tests are passing and which need more work |
Contributor
Author
|
Passing:
Not passing:
All of the tests that don't pass have comments with either exceptions they throw, or short explanations of what went wrong. Other tests that are in the ticket, but not in this pr, don't work because of either non functioning event listeners (addBeforeQueryListener and similar), or they lack exception types. |
Contributor
|
Let's remove the tests that don't pass yet from this PR. We'll include them in second phase. Mark them as unresolved on YouTrack issue @yh-0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.hibernatingrhinos.com/issue/RDBC-782/Python-client-various-tests-2
Part of the tests that I was able to write. note that some of them don't give expected results.