Allow rotation to pass through #387
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Not sure I understand the use case here. I recommend double-wrapping your component instead of requiring a core lib modification. |
Closed
Simple. Double wrapping breaks any |
Collaborator
|
You can use a querySelector for That said, I can't accept this with all the |
|
Double wrapping also drags in relation to the rotated parent |
Collaborator
|
Closing this PR as stale. This PR has been open since 2019 without being merged. See PR #751 for a more recent implementation of rotation support. Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the transform css and svg attribute to allow for rotation to be passed through.