chore(global-header): add missing BUI dependency #2063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christoph-jerolimov
requested review from
a team,
ciiay and
divyanshiGupta
as code owners
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
christoph-jerolimov
force-pushed
the
global-header/add-bui
branch
from
34e6466 to
e5efbc3
Compare
dzemanov
requested changes
Jan 14, 2026
Member
dzemanov
left a comment
dzemanov
left a comment
There was a problem hiding this comment.
Does import '@backstage/ui/css/styles.css'; needs to be added also to dev/index.ts?
christoph-jerolimov
force-pushed
the
global-header/add-bui
branch
from
e5efbc3 to
3fadc3b
Compare
Member
Author
|
@dzemanov the dev pages looked already good but I added it anyway. Please take a new look. Thanks. |
christoph-jerolimov
force-pushed
the
global-header/add-bui
branch
from
3fadc3b to
7c35a7e
Compare
dzemanov
requested changes
Jan 20, 2026
workspaces/global-header/plugins/global-header-test/package.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
christoph-jerolimov
force-pushed
the
global-header/add-bui
branch
from
7c35a7e to
3bcf2c2
Compare
|
dzemanov
approved these changes
Jan 20, 2026
dzemanov
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
When testing the global-header workspace I noticed this white background behind the app in the dark theme.
Before:
With this PR:
✔️ Checklist