Skip to content

Conversation

@its-mitesh-kumar
Copy link
Member

@its-mitesh-kumar its-mitesh-kumar commented Jan 20, 2026

Summary

This PR adds missing settings.displayMode.* translations to the Japanese (ja) and Italian (it) locale files in the Lightspeed plugin.

Changes

Added the following translation keys to ja.ts and it.ts:

  • settings.displayMode.label
  • settings.displayMode.overlay
  • settings.displayMode.docked
  • settings.displayMode.fullscreen

UI after changes

Screen.Recording.2026-01-20.at.8.04.12.PM.mov

Fixed

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Jan 20, 2026

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-lightspeed workspaces/lightspeed/plugins/lightspeed patch v1.2.0

@sonarqubecloud
Copy link

@its-mitesh-kumar
Copy link
Member Author

/cc @ciiay

@openshift-ci openshift-ci bot requested a review from ciiay January 20, 2026 14:48
Copy link
Contributor

@HusneShabbir HusneShabbir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Screenshot 2026-01-20 at 8 29 01 PM
Screenshot 2026-01-20 at 8 29 16 PM

@its-mitesh-kumar
Copy link
Member Author

@christoph-jerolimov @ciiay Do we need to get approval from translation team for these strings to get this PR merged ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants