Golang client for replicated SDK#375
Open
debarshibasak wants to merge 4 commits intoreplicatedhq:mainfrom
Open
Golang client for replicated SDK#375debarshibasak wants to merge 4 commits intoreplicatedhq:mainfrom
debarshibasak wants to merge 4 commits intoreplicatedhq:mainfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| return readAPIError(resp) | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
PostIntegrationMockData duplicates existing doSend helper logic
Low Severity
PostIntegrationMockData manually marshals JSON, calls doRequest, defers body close, and checks the status code — exactly what doSend already does. Every other write-style method (SendCustomAppMetrics, UpdateCustomAppMetrics, DeleteCustomAppMetricsKey, SendAppInstanceTags) delegates to doSend. This function could simply be return c.doSend(ctx, http.MethodPost, "/api/v1/integration/mock-data", body), avoiding duplicated logic and inconsistent maintenance.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR involves the addition of a Golang client that retrieves license details from a replicated service.
Does this PR introduce a user-facing change?
Yes