Skip to content

common: Clock epoch_debug() , timestamp in micros#189

Open
mikelngelous wants to merge 3 commits intoriebl:masterfrom
mikelngelous:master
Open

common: Clock epoch_debug() , timestamp in micros#189
mikelngelous wants to merge 3 commits intoriebl:masterfrom
mikelngelous:master

Conversation

@mikelngelous
Copy link

In case there are multiple receptions from different services, it is a good idea to know when they arrive, even at the different layers, here is an example in the RouterContext

@riebl
Copy link
Owner

riebl commented May 12, 2023

I like your idea @mikelngelous, I am just not convinced that the string formatting should become a method of vanetza::Clock. Also, calling std::chrono::high_resolution_clock could be quite confusing in the end because "clock ticking" is solely handled by vanetza::Runtime everywhere else.

@mikelngelous
Copy link
Author

@riebl you are right. Now I've used runtime to get the timestamp. Do I have to make a new pull request ? also for new contributions like udp unicast that I've pushed

@riebl
Copy link
Owner

riebl commented May 21, 2023

Sorry for my late reply; I have been away for a few days. I prefer to have pull requests per feature, i.e. your UDP feature for socktap would be a separate pull request.
What is the reason that you have closed your PR @mikelngelous?

@mikelngelous mikelngelous reopened this May 26, 2023
@mikelngelous
Copy link
Author

It is reopened again.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants