fix: filter out -std= arguments from pkg-config dependencies#30
Open
fix: filter out -std= arguments from pkg-config dependencies#30
Conversation
As written, it was ony setting a local variable instead of actually setting the standard
The logic as present will not make sure we use the latest standard. That is, we will use the last standard present *and* the usage of direct arguments is overriding all other mechanisms. This makes packages actually impossible to compile without also explicitly setting a -std= argument in the task's CMakeLists.txt Given that the 'cxx_standard' mechanism is setting the target's related feature, I think it's fair to stop propagating these options.
| <% if project.cxx_standard %> | ||
| # override the c++ standard with the final result at generation time | ||
| cxx_standard = "<%= project.cxx_standard %>" | ||
| cxx_standard "<%= project.cxx_standard %>" |
Contributor
There was a problem hiding this comment.
Oops, thanks for catching this. better late than never.
Contributor
|
In my opinion, the behavior before was just plain broken: depending on the order of including other packages one would get the right or wrong standard, and a different package can make your package build or not build. See tests: https://github.com/rock-core/build_tests-orogen-cxx_standards_11_then_14 https://github.com/rock-core/build_tests-orogen-cxx_standards_14_then_11 |
pierrewillenbrockdfki
approved these changes
Feb 16, 2026
Contributor
pierrewillenbrockdfki
left a comment
pierrewillenbrockdfki
left a comment
There was a problem hiding this comment.
Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic as present will not make sure we use the latest standard. That is, we
will use the last standard present and the usage of direct arguments is
overriding all other mechanisms. This makes packages actually impossible to
compile without also explicitly setting a -std= argument in the task's
CMakeLists.txt
Given that the 'cxx_standard' mechanism is setting the target's related feature,
I think it's fair to stop propagating these options.
However, this breaks backward compatibility. Not super happy about that.