Install openssl 1.0.2 on windows to use with connext#490
Install openssl 1.0.2 on windows to use with connext#490mikaelarguedas wants to merge 2 commits intomasterfrom
Conversation
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
…sl 1.0.2 Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
|
This PR introduces further conflicts with #425 which I'm hesitant to merge. Regarding the removal of opensplice as a dependency I would rather see that change made across all platforms rather than "snuck in" to an unrelated PR. I don't mind if it stays in the meantime while you iterate. How confident are you that both OpenSSL installations are non-conflicting and being used? The 1.1.1g binaries default to installing in a separate path from the 1.0.2 binaries unless there was an existing installation of 1.0.2 previously in which case I've seen them use the same install paths. If there are log excerpts from the test builds which show the correct OpenSSL version being used in both scenarios can you please add them to the PR body. |
👍
Not very, this is why I was originally attempting to use the ones provided by RTI where we had a good handle on the installation location. Unfortunately those never seem to have worked on the windows job configuration. |
|
@mikaelarguedas we've moved our Windows setup into a chef cookbook that's invoked from CI (#425). Would you be willing to create a PR for the chef cookbook, then we can use this PR to test the cookbook changes. Based on my experience with local VMs the OpenSSL installers being used here share some Windows registry values which lead me to suspect that by default they'll install on top of each other. I'm not sure if there are command line parameters which can be passed to the installers to control install location explicitly but that needs to be investigated before we can confidently make use of both OpenSSL distributions. |
|
I'm not sure how to go about this, I'll go ahead and close this PR. |
Redo of #421 as requested in #421 (comment)
This installs openssl 1.0.2 alongside openssl 1.1.1.
Relies on ros2/system_tests#439
First commit is unrelated to this change but was useful to reduce CI time, it can be removed from this PR if not sensible
Debug
Release: