Perform all apt operations except those targeting the ROS repositories before daily invalidation.#639
Open
nuclearsandwich wants to merge 1 commit intomasterfrom
Open
Conversation
clalancette
approved these changes
Mar 18, 2022
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
This looks reasonable to me; I agree that this was probably an oversight. I'll just leave a gentle reminder that any changes to the Dockerfile are going to interfere with our current "use a cached Jammy docker image with Python 3.9" strategy. But I'm sure you'll merge this when appropriate.
…s before daily invalidation. There is no reason that these installations should be performed after the daily cache bust. As far as I can tell their presence here is entirely accidental. The ROS 1 packages being installed after invalidation makes some sense since ROS distributions change more frequently than the base Ubuntu or Debian release.
nuclearsandwich
force-pushed
the
nuclearsandwich/keep-apt-updates-valid
branch
from
ac4c1ac to
2f44b07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no reason that these installations should be performed after the daily cache bust. As far as I can tell their presence here is entirely accidental.
The ROS 1 packages being installed after invalidation makes some sense since ROS distributions change more frequently than the base Ubuntu or Debian release.