Skip to content

Fix ExecuteLocal output flushing#860

Merged
fujitatomoya merged 1 commit intoros2:humblefrom
mhidalgo-rai:backport/fix-execute-output-flushing
Apr 23, 2025
Merged

Fix ExecuteLocal output flushing#860
fujitatomoya merged 1 commit intoros2:humblefrom
mhidalgo-rai:backport/fix-execute-output-flushing

Conversation

@mhidalgo-rai
Copy link

@mhidalgo-rai mhidalgo-rai commented Apr 16, 2025

Closes #859. Partially backports #679.

@mhidalgo-rai
Fix ExecuteLocal output flushing
a3c9c18 
io.StringIO is not a logging.Logger

Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
@mhidalgo-rai mhidalgo-rai changed the title Fix ExecuteLocal output flushing Fix ExecuteLocal output flushing Apr 16, 2025
@mhidalgo-rai mhidalgo-rai mentioned this pull request Apr 16, 2025
Closed
fujitatomoya
fujitatomoya approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI.

@fujitatomoya
Copy link
Contributor

fujitatomoya commented Apr 16, 2025 •
edited by christophebedard
Loading

Pulls: #860
Gist: https://gist.githubusercontent.com/fujitatomoya/eb5c0f0057f10804f06ee3078c56589f/raw/11bdb644dd5cebe84d977829fe74fb9b2a753f0b/ros2.repos
BUILD args: --packages-above-and-dependencies launch
TEST args: --packages-above launch
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15711

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@mhidalgo-rai
Copy link
Author

mhidalgo-rai commented Apr 22, 2025

Hmm, test failures seem unrelated to this patch.

@fujitatomoya can we re-run the aarch64 job? It failed on a Jenkins hiccup, it seems.

@christophebedard
Copy link
Member

christophebedard commented Apr 22, 2025

Retriggered!

@fujitatomoya
Copy link
Contributor

fujitatomoya commented Apr 23, 2025

dev branch is 127 commits behind from rolling, i think we need to rebase and restart the CI.

@fujitatomoya
Copy link
Contributor

fujitatomoya commented Apr 23, 2025

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Apr 23, 2025

rebase

☑️ Nothing to do

Details
  • any of:
    • #commits > 1 [📌 rebase requirement]
    • #commits-behind > 0 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • -conflict [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]

@fujitatomoya
Copy link
Contributor

fujitatomoya commented Apr 23, 2025

@mhidalgo-bdai can you rebase your branch to rolling? Mergifyio cannot seem to do that. and then I can start the CI again.

@christophebedard
Copy link
Member

christophebedard commented Apr 23, 2025

This PR targets the humble branch 😁

@mhidalgo-rai
Copy link
Author

mhidalgo-rai commented Apr 23, 2025

This PR targets the humble branch 😁

Indeed. This was fixed in Iron by a seemingly unrelated patch, see #679.

@fujitatomoya
Copy link
Contributor

fujitatomoya commented Apr 23, 2025

@mhidalgo-bdai @christophebedard ah sorry 😓 my bad, totally forgot that this is backport.

@fujitatomoya
Copy link
Contributor

fujitatomoya commented Apr 23, 2025

RHEL and Windows warnings are unrelated.

@fujitatomoya fujitatomoya merged commit 801d7cd into ros2:humble Apr 23, 2025
3 checks passed
@mhidalgo-rai mhidalgo-rai deleted the backport/fix-execute-output-flushing branch April 23, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mhidalgo-rai @fujitatomoya @christophebedard