Add /usr/lib/<pkg> and /usr/libexec/<pkg> to search paths#467
Open
Add /usr/lib/<pkg> and /usr/libexec/<pkg> to search paths#467
Conversation
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
dirk-thomas
suggested changes
Mar 19, 2020
Member
dirk-thomas
left a comment
dirk-thomas
left a comment
There was a problem hiding this comment.
The current implementation follows REP 122. Until that REP has been iterated on the implementation shouldn't change.
Member
|
Hey @sloretz, are you still interested in getting this feature in? Perhaps you or I can make PR with a small addition to REP 122. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal following ros2/ci#400 (comment). This PR adds
<ws>/usr/lib/<pkg>and<ws>/usr/libexec/<pkg>to the search paths used byros2 runto comply with the Linux Filesystem Hierarchy Standard. It looks like the current practice of<ws>/lib/<pkg>doesn't match, but I left that in to make this be an enhancement rather than a disruptive change.