This repository was archived by the owner on Jan 14, 2023. It is now read-only.
Merged
Conversation
jubeira
approved these changes
Apr 12, 2018
jubeira
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
I only have one comment regarding this. I think this is good to have even if not all the tests are passing; we can fix them in future PRs.
| } | ||
|
|
||
| @Test | ||
| public void testChannelBufferFixedSizeNoInitialization() { |
There was a problem hiding this comment.
What's the difference between this test and a simple byte array? Should we add a byte array test too?
Member
Author
There was a problem hiding this comment.
Good point. I will see to add tests for byte arrays, although according to this comment ChannelBuffer is the preferred way.
Member
Author
There was a problem hiding this comment.
Found this in the RawMessage interface:
/**
* @deprecated replaced by {@link #setInt8(String, byte)}
*/
void setByte(String name, byte value);
/**
* @deprecated replaced by {@link #setInt8Array(String, byte[])}
*/
void setByteArray(String name, byte[] value);
/**
* @deprecated replaced by {@link #setUInt8(String, byte)}
*/
void setChar(String name, short value);
/**
* @deprecated replaced by {@link #setUInt8Array(String, byte[])}
*/
void setCharArray(String name, short[] value);
Member
Author
|
Thanks @ernestmc; you already have my approval :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds unit test cases for fixed sized arrays with different data types.
Note that currently some tests are not passing and will be addressed in future pull requests like #59 which is pending review.
To run the tests:
Here's a snapshot of the current status of the tests: