Fix a deprecated message about url_blacklist#202
Merged
hsbt merged 1 commit intoruby:masterfrom Apr 22, 2025
Merged
Conversation
Passing strings to blacklist/whitelist is deprecated. This PR fixes it to remove deprecate messages. https://github.com/ruby/TryRuby/actions/runs/14211217635/job/39818646230#step:4:47 https://github.com/rubycdp/cuprite/blob/4fa812640823e160cb359f40291fe8cf88e05cca/lib/capybara/cuprite/browser.rb#L251 Also, the config name is `url_blocklist` now. https://github.com/rubycdp/cuprite?tab=readme-ov-file#url-blocklisting--allowlisting The old name can be used for backward compatibility. But I think there is no reason to use the old one. So this PR also changed the name to the new one.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing strings to blacklist/whitelist is deprecated. This PR fixes it to remove deprecate messages.
https://github.com/ruby/TryRuby/actions/runs/14211217635/job/39818646230#step:4:47 https://github.com/rubycdp/cuprite/blob/4fa812640823e160cb359f40291fe8cf88e05cca/lib/capybara/cuprite/browser.rb#L251
Also, the config name is
url_blocklistnow.https://github.com/rubycdp/cuprite?tab=readme-ov-file#url-blocklisting--allowlisting
The old name can be used for backward compatibility. But I think there is no reason to use the old one. So this PR also changed the name to the new one.