Open
Conversation
|
I also got confused by this when reading through the FAQ. I asked on reddit and someone pointed out that before ruby 1.9.1 modifying a proc parameter would modify the outer variable of the same name, so it seems this section of the FAQ was written before then and hasn't been updated |
nevans
commented
Aug 15, 2023
| ### How do I pass arguments to a block? | ||
|
|
||
| Typically, arguments are passed to a block using `yield` (or an iterator | ||
| that calls `yield`), or by using the `Proc.call` method. |
Contributor
Author
There was a problem hiding this comment.
I had previously just moved this paragraph to the top, but it should also be altered to use the appropriate syntax to indicate an instance method on Proc. I prefer the # syntax, but this should use whichever is most consistent with other parts of this FAQ.
Suggested change
| that calls `yield`), or by using the `Proc.call` method. | |
| that calls `yield`), or by using the `proc.call` method. |
Suggested change
| that calls `yield`), or by using the `Proc.call` method. | |
| that calls `yield`), or by using the `Proc#call` method. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is misleading: "that variable will be modified by the call to the block"
The outer variable isn't mutated; they are different variables. The name points to one variable outside the block and a different variable inside the block. I'm not sure if my proposed change is better though! 😉
Also, I moved the "arguments are passed" paragraph to the top. The original ordering was fine: it's reasonable to describe how to define block parameters first, and then how to pass arguments in them. But it seems like reversing the order is the most direct answer to the question, as the question is worded. Perhaps the original order was better, but we should add a second question heading: "How do I define a block's parameters"