Conversation
Deploying www-ruby-lang-org with
|
| Latest commit: |
e3c5e42
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6fd46adb.www-ruby-lang-org.pages.dev |
| Branch Preview URL: | https://add-css-ci-check.www-ruby-lang-org.pages.dev |
There was a problem hiding this comment.
Pull request overview
This pull request adds automated CSS build verification to the CI pipeline as part of the redesign project. The changes ensure that the compiled CSS file stays in sync with the source files by checking it on every pull request.
- Added Node.js setup and CSS build check to the GitHub Actions CI workflow
- Removed
package-lock.jsonfrom.gitignoreto track npm dependencies - Added
package-lock.jsonwith Tailwind CSS and typography plugin dependencies
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Adds Node.js setup, npm dependency installation, and CSS build verification steps before Ruby setup |
.gitignore |
Removes package-lock.json from ignore list to track it in version control |
package-lock.json |
Adds complete dependency tree for Tailwind CSS v3.4.17 and @tailwindcss/typography v0.5.19 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Check CSS is up-to-date | ||
| run: | | ||
| npm run build-css | ||
| git diff --exit-code stylesheets/compiled.css || (echo "Error: compiled.css is out of date. Run 'npm run build-css' and commit the changes." && exit 1) |
There was a problem hiding this comment.
The error message could be improved for clarity. Currently it says "Error: compiled.css is out of date" but it would be more helpful to specify which file needs to be regenerated and how to do it locally. Consider making the message more actionable, for example: "The compiled CSS is out of date. Please run 'npm run build-css' locally and commit the updated stylesheets/compiled.css file."
| git diff --exit-code stylesheets/compiled.css || (echo "Error: compiled.css is out of date. Run 'npm run build-css' and commit the changes." && exit 1) | |
| git diff --exit-code stylesheets/compiled.css || (echo "Error: The compiled CSS is out of date. Please run 'npm run build-css' locally and commit the updated stylesheets/compiled.css file." && exit 1) |
|
I'm not sure why +.rounded{
+ border-radius: 0.25rem;
+}
+
.rounded-2xl{
border-radius: 1rem;
}
@@ -4567,6 +4571,10 @@ body:is(.dark *){
text-decoration-line: underline;
}
... |
20e119a to
e672ba1
Compare
- Add Node.js setup and npm ci to CI workflow - Verify compiled.css is up-to-date by rebuilding and checking for diffs - Add package-lock.json to lock dependency versions - Remove package-lock.json from .gitignore 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
e672ba1 to
e3c5e42
Compare
This is remaining work of redesign project. We should check to css build every PRs.