Open
Conversation
Member
znz
commented
Feb 6, 2026
znz
commented
- Fix broken links to doc/language/box.md
- Change links to box.md from github master branch to docs of 4.0 branch
koic
reviewed
Feb 6, 2026
|
|
||
| A new (experimental) feature to provide separation about definitions. | ||
| For the detail of "Ruby Box", see [doc/language/box.md](https://github.com/ruby/ruby/blob/master/doc/language/box.md). | ||
| For the detail of "Ruby Box", see [doc/language/box.md](https://docs.ruby-lang.org/en/4.0/language/box_md.html). |
Contributor
There was a problem hiding this comment.
doc/language/box.md used to be the path in the ruby/ruby repository. Since it's now a documentation site URL, it might make sense to use a different wording, like "the documentation".
Suggested change
| For the detail of "Ruby Box", see [doc/language/box.md](https://docs.ruby-lang.org/en/4.0/language/box_md.html). | |
| For the detail of "Ruby Box", see [the documentation](https://docs.ruby-lang.org/en/4.0/language/box_md.html). |
Contributor
There was a problem hiding this comment.
Alternatively, since supporting multiple languages can be challenging, it might make sense to leave it as just the URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.