-
Notifications
You must be signed in to change notification settings - Fork 3
making testing better #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
a7cd369 to
bae85cd
Compare
53ae413 to
14a32a6
Compare
examples/tutorials/10_async/00_base/000_hello_acp/tests/test_agent.py
Outdated
Show resolved
Hide resolved
smoreinis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, I'm still not totally clear on what the actual behavior change is when it looks like we were already breaking out of the poll_messages loop when we found the expected messages but I assume I'm missing something here about why this didn't work the way I'm reading it but approving this for now and you can help me understand this when you get a chance.
I think there's also a lint error in 050_agent_chat_guardrails in case you didn't see it.
@smoreinis reverted a lot of these changes back because you were right -> the only thing I added in some of the tests were the early breaking if the messages were all discovered which has sped up some tests |
31e2305 to
b80074a
Compare
The diff looks big but it isn't: