Conversation
Instead of Git tags, it now parses Dockerhub tags instead. Additionally, now it always uses 'latest' as the default tag.
schuellerf
left a comment
There was a problem hiding this comment.
The changes do make sense to me and I'll test and merge if I find more time than today...
xfce-test
Outdated
| LOG=${LOG:-/dev/stdout} | ||
| PARALLEL_BUILDS=${PARALLEL_BUILDS:-0} | ||
| TRAVIS=${TRAVIS:-FALSE} | ||
| TAG='latest' |
There was a problem hiding this comment.
I prefer if it can be overridden if needed
| TAG='latest' | |
| TAG=${TAG:-latest} |
There was a problem hiding this comment.
You're absolutely right, fixing it now.
xfce-test
Outdated
| return 0 | ||
| fi | ||
| done | ||
| # the specified tag doesn't exist on Dockerhub |
There was a problem hiding this comment.
You could move the error message and printing of all tags which are available here.
(or you wanted to make the call more encapsulated?)
Either way I think printing the list of available tags, if not found, would improve the usability alot
|
Okay, your first suggestion was simple to fix, but the second was a bit trickier, and I will admit that my solution is somewhat hacky. # invalid tag (unless it's available locally)
$ export TAG='asdf' && ./xfce-test start
# invalid Dockerhub tag
$ ./xfce-test pull asdfNow it doesn't break anymore, and the output with an invalid tag looks something like this: $ export TAG='asdf' && ./xfce-test start
The tag 'asdf' was not found on Dockerhub
---
The following tags are available on Dockerhub:
latest
audio_test
...
ubuntu_20.04-xfce-4.16pre2
ubuntu_xfce-4.16pre1
xubuntu_19.04
Attempting to find the tag 'asdf' locally...
The tag 'asdf' was not found locally
---
The following tags are available locally:
latest
ubuntu_20.04-xfce-4.16pre2
Unable to find the tag 'asdf' either on Dockerhub or locally, exiting...while the |
Fixes #41.
Instead of Git tags, it now parses Dockerhub tags instead.
Additionally, now it always uses 'latest' as the default tag.