Do not setup set -e in case function analyze_logs_by_logdetective fails
#416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
send the logs to logdetective URL. Setting set +e and afterwards set -e does not make sense. In case sending data to logdetective failed, then continue. In case set -e is set up and failed_version function returns non zero status, than script is immediatelly stopped which does not make sense in case we tested all version. Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Pull Request validationFailed🔴 Failed or pending statuses:
🔴 Review - Missing review from a member (1 required) |
Member
Author
|
@pkhartsk @SlouchyButton PTAL. This should fix the issues sclorg/ci-scripts#183 |
Member
Author
|
[test] |
Testing Farm results
|
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Member
Author
|
Let's test it once again after adding some more descriptive comments. |
Member
Author
|
[test] |
pkhartsk
approved these changes
Jan 8, 2026
Contributor
pkhartsk
left a comment
pkhartsk
left a comment
There was a problem hiding this comment.
Tested with failing tests for nginx container, output:
Test cases results:
[PASSED] for 'test-app' test_s2i_usage (00:00:00)
[PASSED] for 'test-app' test_docker_run_usage (00:00:00)
[PASSED] for 'test-app' test_application (00:00:03)
[FAILED] for 'test-app' test_log_output (00:00:06)
[PASSED] for 'test-app' test_log_volume_output (00:00:02)
[PASSED] for 'test-app' test_application_user (00:00:02)
[PASSED] for 'start-hook-test-app' test_pre_init_script (00:00:02)
[PASSED] for 'perl-test-app' test_perl_directive (00:00:02)
[PASSED] for 'miscellaneous-tests' run_dockerfiles_test (00:00:16)
Tests for ubi9/nginx-126:1.26 failed.
Analyse logs by logdetective, why it failed.
Sending failed log by fpaste command to paste bin.
Sending log file to logdetective server: /tmp/rhel9-1.26.nIyRu4
-------- LOGDETECTIVE TEST LOG ANALYSIS START --------
curl: (3) URL rejected: No host part in the URL
ERROR: Failed to analyze log file by logdetective server.
-------- LOGDETECTIVE TEST LOG ANALYSIS FAILED --------
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Test for image ubi9/nginx-126:1.26 FAILED in these versions 1.20 1.22 1.24 1.26.
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
make: *** [common/common.mk:95: test] Error 1
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not setup
set -ein case functionanalyze_logs_by_logdetectivefailssend the logs to logdetective URL.
Setting set +e and afterwards set -e does not make sense. In case sending data to logdetective failed, then continue.
In case set -e is set up and failed_version function returns non zero status, than script is immediatelly stopped which does not make sense in case we tested all version.