Fix DefaultResultSetFuture not completing for unknown schema changes #794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When handling a schema change response, the `default` case in the switch statement for `scc.change` (which handles unknown schema change types) was missing a call to `set(rs)`. This caused the future to never complete if an unknown schema change type was received, leading to `getUninterruptibly()` waiting forever. This fix ensures the future always completes, even for unexpected schema change types, by adding `set(rs)` in the default case. Also added a unit test to verify the behavior. Fixes: scylladb#365
nikagra
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DefaultResultSetFuturewould never complete if an unknown schema change type was receiveddefaultcase in the switch statement forscc.changewas missing a call toset(rs)Details
When handling a schema change response in
DefaultResultSetFuture.onSet(), thedefaultcase in the switch statement forscc.change(which handles unknown schema change types) was missing a call toset(rs). This caused the future to never complete if an unknown schema change type was received, leading togetUninterruptibly()waiting forever.Test plan
DefaultResultSetFutureTest.should_complete_future_for_schema_change_responseFixes #365