feat(protocol): DaoPriortity issues #62
Conversation
sector-3#61 [x] sector-3#60 [x] sector-3#51 [x] sector-3#42 [x]
|
@aahna-ashina I'm going to need to update the tests here but the implementations are ready, I was worried about leaving a little gas-less and safe |
aahna-ashina
left a comment
aahna-ashina
left a comment
There was a problem hiding this comment.
@developerfred Thank you for contributing 😄
This PR solves multiple issues in one commit, so it's difficult to review. I suggest you create smaller pull requests, with one pull request per issue.
Also note that some of the issues in this PR are for functionalities that will not be added in version 1 of the protocol, so we cannot merge code changes for version 2 until version 1 has been released.
To make this distinction more clear, I've labeled the issues by protocol version: https://github.com/orgs/sector-3/projects/1
And the milestones can be seen here: https://github.com/sector-3/protocol/milestones
|
@aahna-ashina Perfect, I'll make those changes tomorrow. I will divide this pull request into features and take advantage and add the tests. I also want to propose that we use a Standard for solidity to divide the logic of the contracts because I believe that as the project grows it will be better to scale and create small issues |
2 participants
Related GitHub Issue
How Has This Been Tested?
Sector#3 Contribution