-
Notifications
You must be signed in to change notification settings - Fork 4
Update documentation #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@aciddjus, since we are updating documentation, let's also update this part to reflect new free tier (README.md#account-api): {
account_id: "1234567890",
api_key: "your_secret_key",
account_email: "email@company.com",
account_status: "Active",
plan_id: "free",
plan_name: "Free Plan",
plan_monthly_price: 0.0,
searches_per_month: 100,
plan_searches_left: 0,
extra_credits: 100,
total_searches_left: 10,
this_month_usage: 100,
this_hour_searches: 0,
last_hour_searches: 0,
account_rate_limit_per_hour: 100
} |
ocvit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @aciddjus!
There are so many other bad wordings, badly formatted lines and hardly readable/understandable code examples here. Should we fix them all? I can jump on it.
Co-Authored-By: Dmytro Horoshko <13473505+ocvit@users.noreply.github.com> Co-Authored-By: Muhammad Ovi (Owais) <contact@muhammadovi.com>
jvmvik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution
ocvit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jvmvik! 👍
ocvit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jvmvik! 👍
We can remove Layout/FirstHashElementIndentation override in .rubocop.yml as it's not needed anymore. Otherwise LGTM!
Few mostly grammatical fixes.