Skip to content

Conversation

@aciddjus
Copy link
Contributor

Few mostly grammatical fixes.

@aciddjus aciddjus requested a review from jvmvik July 30, 2025 14:26
@Ovi
Copy link
Contributor

Ovi commented Jul 30, 2025

@aciddjus, since we are updating documentation, let's also update this part to reflect new free tier (README.md#account-api):

{
 account_id: "1234567890",
 api_key: "your_secret_key",
 account_email: "email@company.com",
 account_status: "Active",
 plan_id: "free",
 plan_name: "Free Plan",
 plan_monthly_price: 0.0,
 searches_per_month: 100,
 plan_searches_left: 0,
 extra_credits: 100,
 total_searches_left: 10,
 this_month_usage: 100,
 this_hour_searches: 0,
 last_hour_searches: 0,
 account_rate_limit_per_hour: 100
} 

Copy link
Contributor

@ocvit ocvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aciddjus!

There are so many other bad wordings, badly formatted lines and hardly readable/understandable code examples here. Should we fix them all? I can jump on it.

@aciddjus
Copy link
Contributor Author

aciddjus commented Jul 31, 2025

Thank you @aciddjus!

There are so many other bad wordings, badly formatted lines and hardly readable/understandable code examples here. Should we fix them all? I can jump on it.

@ocvit Yeah, for sure. Thanks for the help 👍

Co-Authored-By: Dmytro Horoshko <13473505+ocvit@users.noreply.github.com>
Co-Authored-By: Muhammad Ovi (Owais) <contact@muhammadovi.com>
@aciddjus aciddjus requested a review from ocvit July 31, 2025 10:30
Copy link
Contributor

@jvmvik jvmvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution

Copy link
Contributor

@ocvit ocvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jvmvik! 👍

@jvmvik jvmvik requested a review from ocvit August 5, 2025 01:50
@jvmvik jvmvik self-assigned this Aug 5, 2025
Copy link
Contributor

@ocvit ocvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jvmvik! 👍

We can remove Layout/FirstHashElementIndentation override in .rubocop.yml as it's not needed anymore. Otherwise LGTM!

@jvmvik jvmvik merged commit 37c17ae into master Aug 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants