fix: incorrect upload-artifact destination directory; Add right-click item lookup function on Huiji Wiki#1
Open
YLTai wants to merge 3 commits intosharkycorps:cnfrom
Open
fix: incorrect upload-artifact destination directory; Add right-click item lookup function on Huiji Wiki#1YLTai wants to merge 3 commits intosharkycorps:cnfrom
YLTai wants to merge 3 commits intosharkycorps:cnfrom
Conversation
added 3 commits
September 28, 2024 05:19
…nation directory from 'InventoryTools' to 'InventoryToolsCN'. - Added a new option in the RightClickService to search for items on the FFXIV-CN HuijiWiki.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR primarily addresses the issue of the incorrect upload-artifact destination directory.
.github/workflows/build.yml:InventoryTools/bin/Release/InventoryToolstoInventoryTools/bin/Release/InventoryToolsCN.InventoryTools/Services/RightClickService.cs:Additional Note
感谢作者在适配工作上的努力！尽管作者已使国际服插件基本适配国服，但仍有一些细节与国服不完全兼容，例如市场价格查询的区服选择、右键查询功能以及本地化翻译等。考虑到这些问题的开发难度相对较低，且前期适配开发人员较少，我希望能直接与您讨论这些适配工作的具体细节。期待您的回复！