Update Kitodo.Production and scripts for webhook manager version#98
Update Kitodo.Production and scripts for webhook manager version#98
Conversation
bertsky
left a comment
There was a problem hiding this comment.
perhaps this PR should also link to slub/ocrd_manager#66
|
@bertsky Adjusted to the changed asynchronous behavior of OCR-D manager. Synchronous is now the default. |
bertsky
left a comment
There was a problem hiding this comment.
LGTM.
Just needs to be updated to new Manager (after slub/ocrd_manager#66 itself is finished and merged), and one minor change may be required (see below).
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
|
Wait! One bug did slip through: Lines 22 to 23 in b8a3885 Notice the wrong variable name for the pw? Live this causes: |
|
Also fixed in c59b4cb. |
|
@markusweigelt, short explanation: in trying to make this work, I noticed I do need to update the Controller (because our timeout was partially caused by glitches there, not SSH itself) and added waiting for ocrd-database (because that is what surfaced on the CI as well). So I basically had to put all on one card. Hope all this is sufficient now 🤞 |
|
Ok, it finally (!!) seems to work again. For the moment, only locally – but on the CI all we are waiting for is a release of ocrd/core v2.62.3 to PyPI, so ocrd/all:maximum-cuda can be rebuilt (it does already work with ocrd/all:maximum). I already merged the new Controller, so IMO the next steps should be:
|
SERVICESenv, confirm make down