Fix #454: Add end-to-end tests for the plugin-related SoftwareMetadata API
#456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdruskat
changed the base branch from
refactor/data-model
to
refactor/423-implement-public-api
sdruskat
force-pushed
the
feature/454-e2e-test-plugin-api
branch
from
f45d9b4 to
9be8041
Compare
Contributor
Author
|
Re-opening after rebase on correct branch. |
SKernchen
reviewed
Jan 30, 2026
| try: | ||
| monkeypatch.setattr(context_manager.HermesContext.__init__, "__defaults__", (tmp_path.cwd(),)) | ||
| cli.main() | ||
| except SystemExit: |
Contributor
There was a problem hiding this comment.
I don't like the use of SystemExit, can't we just use the code directly and skip the try
Collaborator
There was a problem hiding this comment.
Not really, cli.main() always calls sys.exit().
On feature/454-e2e-deposit I've changed the try-except-finally to read:
try:
monkeypatch.setattr(context_manager.HermesContext.__init__, "__defaults__", (tmp_path.cwd(),))
cli.main()
except SystemExit as e:
if e.code != 0:
raise e
finally:
# validation of resultsI hope that this is better.
| try: | ||
| monkeypatch.setattr(context_manager.HermesContext.__init__, "__defaults__", (tmp_path.cwd(),)) | ||
| cli.main() | ||
| except SystemExit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.