Addressbook: Add foreign key, dependent/inverse_of options #6265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to satisfy Rubocop, but it's also just good behavior. If a user record is destroyed, we should also destroy their address book. For the default addresses, we don't add cascading deleted, because these are also present in the `has_many :user_addresses`.
Join records are absolutely useless if either of their "arms" are missing. Make them mandatory.
I'm only adding a foreign key constraint between user_addresses and addresses, not for users, because that should be the responsibility of the user class, so we could i.e. do it in solidus_auth_devise.
github-actions
bot
added
the
changelog:solidus_core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6265 +/- ##
=======================================
Coverage 88.82% 88.83%
=======================================
Files 850 850
Lines 18334 18336 +2
=======================================
+ Hits 16286 16288 +2
Misses 2048 2048 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This makes the user address book a little more reliable by adding a foreign key constraint between addresses and address book entries, and making sure that address book entries have both an address and a user.
I think the
optional: truemade it in here when the default changed in Rails forbelongs_toassociations, but these were never optional.Extracted from #6240
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: