Skip to content

Changes to the FormulaManager.equal and FormulaManager.distinct API#584

Merged
kfriedberger merged 9 commits intomasterfrom
genericEqualityChanges
Feb 10, 2026
Merged

Changes to the FormulaManager.equal and FormulaManager.distinct API#584
kfriedberger merged 9 commits intomasterfrom
genericEqualityChanges

Conversation

@daniel-raffler
Copy link
Contributor

As suggested by @PhilippWendler:

  • We now allow Iterables as arguments for FormulaManager.equal and FormulaManager.distinct
  • The methods have been renamed to makeEqual and makeDistinct
  • We use FluentIterable to avoid unnecessary copying

See #559 for the discussion

baierd
baierd previously approved these changes Jan 19, 2026
Copy link
Contributor

@baierd baierd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kfriedberger kfriedberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks valid now.

@kfriedberger kfriedberger merged commit cf82f84 into master Feb 10, 2026
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants